Update crc requirement from 1 to 3 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
|
The following labels could not be found: |
dependabot
bot
force-pushed
the
dependabot/cargo/crc-3
branch
2 times, most recently
from
3697daa
to
6f32841
Compare
|
some info for migrating here mrhooray/crc-rs#62 |
dependabot
bot
force-pushed
the
dependabot/cargo/crc-3
branch
from
6f32841
to
1b34ee5
Compare
Updates the requirements on [crc](https://github.com/mrhooray/crc-rs) to permit the latest version. - [Release notes](https://github.com/mrhooray/crc-rs/releases) - [Commits](mrhooray/crc-rs@1.0.0...3.0.0) --- updated-dependencies: - dependency-name: crc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/cargo/crc-3
branch
from
1b34ee5
to
f6bba09
Compare
|
I finally got something working here by following the discussion mentioned previously. This part of the code is covered by unit tests which I was able to see failing with a different implementation. I am not 100% confident TBH but I think it looks fine. |
e-ivkov
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on crc to permit the latest version.
Release notes
Sourced from crc's releases.
Commits
b6dc600Prepare 3.0.0 release12c17fbDocument behavior of digest_with_initial60861d8Apply refin and width to custom initial values2ef1be5Add Crc::digest_with_initial4aeef11impl Clone for Digestf0e62a3Remove use of BITS associated const4a9a15bAdd support for up to 128 bit CRCs384fb68Add support for CRC algorithms which have a non-power of 2 widthf1294c9Prepare 2.1.0 release7ace659Replace Travis CI with GitHub ActionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)